Fixed issue with fexpect sending __init__.py to remote system (instead of entire pexpect directory) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of entire pexpect directory)
|
Hi Jim, appreciate your contribution! Could you give a few more details on when this happens for you? it seems that for most people 'pexpect.py' is picked correctly, and I would prefer just sending one file instead of a whole directory. |
|
Hi back, I am currently swamped at work and don't have room to go back and get more details on this right now. I know that's not very helpful, but I wanted to at least check in. If I have the chance to look back at this, I'll post an update on this ticket - thanks!! Jim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method wrapExpectations() in internals.py is responsible for uploading the pexpect library to the remote system. The current code assumes that pexpect is a single file (pexpect.py) when instead pexpect is a package containing several files (see https://github.com/pexpect/pexpect/tree/master/pexpect). When it tries to locate pexpect, it selects pexpect/init.py instead of the entire folder. When fexpect tries to run the remote script, the script fails to import pexpect and dies.
This commit modifies the code so that it correctly pushes the entire pexpect directory to the remote system.