Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jax dependency to 0.4.10 and removed the temporary pin #278

Closed
wants to merge 0 commits into from

Conversation

eugene
Copy link

@eugene eugene commented May 24, 2023

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've formatted the new code by running poetry run pre-commit run --all-files --show-diff-on-failure before committing.
  • I've added tests for new code.
  • I've added docstrings for the new code.

Description

Bumped jax dependency to 0.4.10 and removed the temporary pin on jaxlib=0.4.7 as jax/issues/15951 is fixed

Issue Number: N/A

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into GPJax!

If you have not heard from us in a while, please feel free to ping @gpjax/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on Slack for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@eugene eugene changed the title Bumped jax dependency to 0.4.10 and removed the temporary pin Bump jax dependency to 0.4.10 and removed the temporary pin May 24, 2023
@thomaspinder
Copy link
Collaborator

Hey @eugene (nice to see you here!). It looks like some tests are failing. Did you manually remove the jaxlib dependency, or did you use poetry commands? It looks like the former, which would explain the failing tests. I think you want something like poetry remove jaxlib e.g., https://python-poetry.org/docs/cli/#remove

@eugene
Copy link
Author

eugene commented May 25, 2023

hej @thomaspinder - thanks for this epic project!. The thing with poetry is that it fails in a fresh conda environment here. I've tried to delete the .lock file and do a fresh poetry install in a fresh conda enironment (python=3.10.0 as suggested by readme) which results in this bug (psf/cachecontrol#292):

'HTTPResponse' object has no attribute 'strict'

So the idea was to just fix the .toml with bumped jax version and yolo it through the CI.

@thomaspinder
Copy link
Collaborator

Hey @eugene ! Could you try running the following commands and updating please?

poetry add "jaxblib>=0.4.10"
poetry lock --no-update

@eugene eugene closed this Jun 26, 2023
@eugene eugene force-pushed the main branch 2 times, most recently from 13ba8e0 to e98050e Compare June 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants