-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a library that can be imported #5
base: master
Are you sure you want to change the base?
Conversation
I've added a check for seeing if you've hit your rate limit for the github api. Should be a temp fix for errors thrown by #4 |
This PR adds a lot of redundancy. However, adding redundancy is not acceptable in my opinion (especially if we have issues like #4 or #3 which now affect the duplicated code). An API might also not be suitable until we figure out #1 so that the API could remain stable. |
This project is just something I'm using for a little project of mine (https://github.com/Titaniumtown/yatopia-autoupdate) a minecraft server updater, that auto-fetches the latest artifact of a specific branch. |
That's all fine, but I don't think your changes are upstreamable (to this project) for the reasons I described before. With the master branch, I keep getting this for my own repositories (which is the issue described by #4):
So the HTTP server would have to be a logged in GitHub User of some form, which is not acceptable to me. I don't see how your modifications would work around this problem, or how your repository can be configured to avoid this? |
I whipped up this "library version" of main.py which can be imported. So one could just import it like:
from artifact_lib import get_latest_artifact_url