Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Event::event_type #55

Merged
merged 1 commit into from
Sep 1, 2024
Merged

feat: add Event::event_type #55

merged 1 commit into from
Sep 1, 2024

Conversation

Rodrigodd
Copy link
Contributor

Need it for registering events listeners dynamic, and is not possible to maintain this code downstream due to non_exhaustive.

@Rodrigodd Rodrigodd mentioned this pull request Jul 20, 2024
Merged
@JayceFayne JayceFayne self-requested a review September 1, 2024 13:07
JayceFayne
JayceFayne requested changes Sep 1, 2024
View reviewed changes
Copy link
Owner

@JayceFayne JayceFayne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late response, I seem to have missed this pr

types/src/event.rs Outdated Show resolved Hide resolved
@Rodrigodd
Copy link
Contributor Author

@JayceFayne Done, moved the impl to types/src/utils/event.rs.

@JayceFayne JayceFayne self-requested a review September 1, 2024 14:59
@JayceFayne
Copy link
Owner

LGTM. Thanks!

@JayceFayne JayceFayne merged commit 9523946 into JayceFayne:master Sep 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayceFayne JayceFayne Awaiting requested review from JayceFayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rodrigodd @JayceFayne