Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bleak max_write_without_response_size and current bleak MTU #141

Merged
merged 6 commits into from
Aug 9, 2022

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Aug 9, 2022

This is working with the current version of bleak as well and restores the performance that was lost in #139

Also drops .handle calls since hbldh/bleak#888

Needs hbldh/bleak#930 for max_write_without_response_size but we can already get the MTU since the dict is accessible already.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #141 (5ad7f66) into main (1eec367) will decrease coverage by 0.12%.
The diff coverage is 4.16%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   70.99%   70.87%   -0.13%     
==========================================
  Files          70       70              
  Lines        5817     5833      +16     
==========================================
+ Hits         4130     4134       +4     
- Misses       1687     1699      +12     
Flag Coverage Δ
unittests 70.87% <4.16%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohomekit/controller/ble/discovery.py 37.20% <0.00%> (ø)
aiohomekit/controller/ble/pairing.py 24.39% <0.00%> (ø)
aiohomekit/controller/ble/client.py 26.53% <4.76%> (-3.96%) ⬇️
aiohomekit/controller/ip/connection.py 87.04% <0.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdraco bdraco changed the title Add support for bleak max_write_without_response_size Add support for bleak max_write_without_response_size and current bleak MTU Aug 9, 2022
@bdraco bdraco marked this pull request as ready for review August 9, 2022 20:06
@bdraco
Copy link
Collaborator Author

bdraco commented Aug 9, 2022

Tested with 8 different devices. Pairing back to same speed 👍

@bdraco bdraco merged commit c7b42ca into main Aug 9, 2022
@Jc2k Jc2k deleted the bleak_max_write_without_response_size branch July 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants