**DO NOT MERGE** Set sensible COAP timeouts for sleepy thread devices #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 74.47% 74.41% -0.06%
==========================================
Files 99 99
Lines 9331 9353 +22
==========================================
+ Hits 6949 6960 +11
- Misses 2382 2393 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Thread devices are sleepy - CoAP packets queue at routers. They are then delivered when the device wakes up.
In some cases the default sleep intervals are longer that the default CoAP timeouts. Upstream added TransportTuning for us, which lets us avoid timeouts (timeouts cause retries etc).
For a CoAP pairing where we have an Accessory Runtime Information service and a Sleep Interval characteristic, set the ACK timeout based on that interval.