Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make process_changes return a set of what actually changed #339

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Oct 20, 2023

I realized we still write state too frequently. When we do the poll if the value is the same we still callback the entity.

Will be used in home-assistant/core#102370

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0c037f4) 74.45% compared to head (1326365) 74.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   74.45%   74.42%   -0.04%     
==========================================
  Files          99       99              
  Lines        9246     9266      +20     
==========================================
+ Hits         6884     6896      +12     
- Misses       2362     2370       +8     
Files Coverage Δ
aiohomekit/model/__init__.py 95.87% <100.00%> (+0.13%) ⬆️
aiohomekit/model/characteristics/characteristic.py 77.23% <100.00%> (+0.20%) ⬆️
aiohomekit/protocol/statuscodes.py 90.90% <100.00%> (-0.27%) ⬇️
tests/test_model.py 100.00% <100.00%> (ø)
tests/test_testing.py 100.00% <100.00%> (ø)
aiohomekit/testing.py 78.92% <60.00%> (-3.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bdraco added a commit to home-assistant/core that referenced this pull request Oct 20, 2023
I realized we still write state too frequently.

When we do the poll if the value is the same we still callback the entity.

needs Jc2k/aiohomekit#339
@bdraco bdraco marked this pull request as ready for review October 20, 2023 08:09
@bdraco bdraco marked this pull request as draft October 20, 2023 08:10
@bdraco
Copy link
Collaborator Author

bdraco commented Oct 20, 2023

thanks, will release shortly

@bdraco bdraco marked this pull request as ready for review October 20, 2023 17:53
@bdraco bdraco merged commit 54a6232 into main Oct 20, 2023
8 of 9 checks passed
@bdraco bdraco deleted the process_changes branch October 20, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants