-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for happy eyeballs (RFC 8305) #349
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 74.42% 74.50% +0.08%
==========================================
Files 99 99
Lines 9273 9301 +28
==========================================
+ Hits 6901 6930 +29
+ Misses 2372 2371 -1 ☔ View full report in Codecov by Sentry. |
I'm seeing duplicate IPv6 addresses I think its a bug in zeroconf. Going to have to fix that first |
bug in zeroconf fixed in 0.128.2+ Will bump the min version here and the dep in HA |
tests fail with new zeroconf because Will re-expose it for now python-zeroconf/python-zeroconf#1327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Do you think it would be safe to allow ipv6 link local whilst working on this? It's much more likely to be a valid addresss than an ipv4 link local.
I fixed up zeroconf to pass the scope_id correctly so we could make ipv6 link local work with some more work but it would need a lot more refactoring to be able to split the |
Thanks. I've just finished the code for all 3 of these PRs. I'm doing testing aiohomekit and aioesphomeapi but I don't want to merge until I'm sure there won't be any breaking changes in the lib |
Thanks. Happy with the other libs, will push a release shortly |
Adds Happy Eyeballs support (https://datatracker.ietf.org/doc/html/rfc8305)
--
This PR is a first step as I need to make sure this library works for the other projects as well. Its likely to sit for a bit while I test the library with all the projects that need it so there aren't any need to do breaking changes before all the other projects start consuming it:
--
This should fix all the cases where
closes #348
likely fixes home-assistant/core#102901