-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scroll lock div work on a document context it belongs to #5347
Conversation
🦋 Changeset detectedLatest commit: f313a13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f313a13:
|
Thanks for your PR @aszmyd. |
I've updated the branch, included the changeset, and prepared two CodeSandbox instances to show the issue:
I also recorded a small demo of the bug (link) - first part shows the behavior on the 5.7.4 version and second (on the second tab of the browser) shows the fix. The bug is that it's not possible to close the opened select by clicking outside of it when the I've used react-new-window package to make a new document context case (it simply opens a new popup window and uses React Portals to render component on it) as I'm using this package also in my current production codebase. As mentioned in the issue description, the problem only occurs when the Please let me know if there is anything else I do to make this merged. Our application has no workaround for this bug and it's quite annoying for the our users currently. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the PR, and for the thorough documentation and examples @aszmyd.
Everything looks good to me, so I'm going to approve and merge it.
Fixes #5346