-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lack of disabled attribute on select element causing color contrast issue #5666
Conversation
🦋 Changeset detectedLatest commit: fb4f8b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb4f8b4:
|
@jjuradok @AriPerkkio @JedWatson Hi, is there any maintainer who can review this PR, please? CC: @mellis481 |
This is a glaring a11y failure (WCAG 1.4.3) that my team is very much hoping can get merged and released soon. |
@jjuradok lo va a ver, tranqui |
@jjuradok, @AriPerkkio @Rall3n @Methuselah96 @craigdallimore |
@lukebennett88, @Methuselah96 Hi, are you able to look at this and get a merge or a list of approving reviews with write access? |
@JedWatson Hi is there anyone who can approve PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the PR, really great to see folk who care about accessibility 🙌
As stated in this issue: #5550
"disabled" is properly set in the input, since it was used instead of aria-disabled, the lack of "aria-disabled" resulted in the automated a11y tool not determining it disabled element and cause a contrast issue.
Ref: UIEN-3643