Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lack of disabled attribute on select element causing color contrast issue #5666

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

yhy-1
Copy link
Contributor

@yhy-1 yhy-1 commented Jun 9, 2023

As stated in this issue: #5550

"disabled" is properly set in the input, since it was used instead of aria-disabled, the lack of "aria-disabled" resulted in the automated a11y tool not determining it disabled element and cause a contrast issue.

Ref: UIEN-3643

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

🦋 Changeset detected

Latest commit: fb4f8b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb4f8b4:

Sandbox Source
react-codesandboxer-example Configuration

@yhy-1 yhy-1 changed the title Lack of disabled attribute on select element causing color contrast issue fix: lack of disabled attribute on select element causing color contrast issue Jun 9, 2023
@yhy-1 yhy-1 marked this pull request as ready for review June 9, 2023 18:29
@yhy-1
Copy link
Contributor Author

yhy-1 commented Sep 14, 2023

@jjuradok @AriPerkkio @JedWatson Hi, is there any maintainer who can review this PR, please?

CC: @mellis481

@mellis481
Copy link

mellis481 commented Sep 14, 2023

This is a glaring a11y failure (WCAG 1.4.3) that my team is very much hoping can get merged and released soon.

@edmilicich
Copy link

@jjuradok lo va a ver, tranqui

@yhy-1
Copy link
Contributor Author

yhy-1 commented Sep 19, 2023

@jjuradok, @AriPerkkio @Rall3n @Methuselah96 @craigdallimore
@jacobsfletch @oscarjg @gwyneplaine
Any new update?

@yhy-1
Copy link
Contributor Author

yhy-1 commented Sep 21, 2023

@lukebennett88, @Methuselah96 Hi, are you able to look at this and get a merge or a list of approving reviews with write access?

@yhy-1
Copy link
Contributor Author

yhy-1 commented Sep 29, 2023

@JedWatson Hi is there anyone who can approve PR ?

Copy link
Collaborator

@lukebennett88 lukebennett88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR, really great to see folk who care about accessibility 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants