-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for React 0.14 #45
Comments
|
Do you have a source for this? @slorber |
Thanks, so I can go through and replace Tappables with normal elements again? |
No I just say that you can remove your call to You can send a PR so that React-tappable do not call it anymore, it's just this line to remove: |
I've just pushed an update with that line removed, thanks @slorber. |
@JedWatson 0.14 has not been released yet, I'm not sure I endorse this change. If there was a way to conditionally call |
@frederickfogerty based on my research:
We could wrap This is all based on my interpretation of the related issues in facebook/react so if I'm wrong, I'm happy to reinstate it with the try/catch for 0.14 compatibility. |
Oh, apologies, I didn't realise it didn't do anything on 0.13 (or even 0.12). In that case, looks fine to me, thanks for the update! |
I tried out React 0.14 today but was met with
Uncaught TypeError: React.initializeTouchEvents is not a function
Related: zilverline/react-tap-event-plugin#24
The text was updated successfully, but these errors were encountered: