Kill React.initializeTouchEvents for good #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
force-pushed
the
kill-initializeTouchEvents
branch
from
b09a801
to
c1eca6d
Compare
Now that facebook#1169 is fixed, the only thing this is used for is to determine whether `onTouchTap` causes touch listeners to be added. The only internal uses of TapEventPlugin are where touch events are already initialized (so this doesn't make a difference) and we don't support `onTouchTap` as part of the public API so this should be safe.
sophiebits
force-pushed
the
kill-initializeTouchEvents
branch
from
c1eca6d
to
9c4c2f5
Compare
|
surewhynot |
sophiebits
added a commit
that referenced
this pull request
Mar 19, 2015
Kill React.initializeTouchEvents for good
This was referenced Oct 13, 2015
aweiksnar
added a commit
to zooniverse/Panoptes-Front-End
that referenced
this pull request
Nov 30, 2015
aweiksnar
added a commit
to zooniverse/Panoptes-Front-End
that referenced
this pull request
Dec 4, 2015
spradnyesh
pushed a commit
to spradnyesh/reagent-forms
that referenced
this pull request
Jun 24, 2016
yogthos
pushed a commit
to reagent-project/reagent-forms
that referenced
this pull request
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #1169 is fixed, the only thing this is used for is to determine whether
onTouchTapcauses touch listeners to be added. The only internal uses of TapEventPlugin are where touch events are already initialized (so this doesn't make a difference) and we don't supportonTouchTapas part of the public API so this should be safe.