Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on initializeTouchEvents, removing tap-delay #2468

Closed
jefffriesen opened this issue Nov 6, 2014 · 8 comments
Closed

Comments

@jefffriesen
Copy link

The documentation on React.initializeTouchEvents(true) could use a little love:
http://facebook.github.io/react/docs/events.html#touch-events

I realize it's currently changing and may be removed (#436, #1170). Is it still required? Is it only required if we use react-tap-event-plugin?

What's most confusing about it is when to use it. Use it if the page being rendered will ever render on a touch device? Or do we detect touch using something like Modernir.touch and then set it to true?

Related to this issue is the tap delay. Maybe suggest in the documentation using a plugin like tap-event-plugin?

I would submit a PR but really don't know what the documentation should say. Thanks!

@mschipperheyn
Copy link

+1

@OscarGodson
Copy link

Yeah, it makes it sound that it will actually use touch events which is does not.

@livtanong
Copy link

+1. At the moment, as of React 0.12 on my project, touch events still trigger on touch devices with or without initializeTouchEvents.

@malissa
Copy link

malissa commented Mar 31, 2015

I'm also curious what this would be used for. I'm loading my react app in a ios simulator and things seem ok without explicitly setting initializeTouchEvents to true. To be fair I haven't tried on an actual device.

@chicoxyzzy
Copy link
Contributor

initializeTouchEvents was removed in #3442 so +1

@chicoxyzzy
Copy link
Contributor

@iamstarkov
Copy link

@chicoxyzzy @jefffriesen I still see note about initializeTouchEvents. is it an error?

To enable touch events, call React.initializeTouchEvents(true) before rendering any component.

@chicoxyzzy
Copy link
Contributor

@iamstarkov looks like the version with fixes is not shipped yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants