Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleDatePicker doesn't work for touch devices in Microsoft Edge #169

Closed
viktoriyavulfson opened this issue Nov 8, 2016 · 3 comments
Closed

Comments

@viktoriyavulfson
Copy link
Contributor

Try to view http://airbnb.io/react-dates in Edge. Clicking on input field doesn't do anything, datepicker view doesn't show up

@viktoriyavulfson viktoriyavulfson changed the title SingleDatePicker doesn't work in Microsoft Edge SingleDatePicker doesn't work for touch devices in Microsoft Edge Nov 8, 2016
@viktoriyavulfson
Copy link
Contributor Author

@majapw is there a reason to disable date input for touch devices? I tried removing disabled attribute in dev tools and everything works fine. Would you guys accept a PR to remove disabled attribute for touch devices?

@moonboots
Copy link
Collaborator

I'm able to reproduce on the SingeDatePicker and DatePickerInput (when clicking on "Start Date" or "End Date", DayPicker still works). @majapw, do we still need special handling for touch devices. It looks like we used to check isTouchDevice to conditionally React.initializeTouchEvents(true), but it looks that method was removed.

@viktoriyavulfson
Copy link
Contributor Author

@moonboots thanks for looking into this! submitted PR to remove the check #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants