Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Review Calendar to highlight stricter downtime conflict #17

Closed
slominskir opened this issue Apr 8, 2024 · 0 comments · Fixed by #18
Closed

Update Review Calendar to highlight stricter downtime conflict #17

slominskir opened this issue Apr 8, 2024 · 0 comments · Fixed by #18

Comments

@slominskir
Copy link
Member

slominskir commented Apr 8, 2024

In #15 we made the cross check for BTM vs DTM downtime cross check stricter to catch more problems. The Review Calendar delegates to the same cross check, however, the highlight in-red DTM discrepancy logic is still using program time when making comparisons to determine if the day should be "red". We need to update the highlight logic to replace program time with possible downtime (Physics + Internal Down) to reflect the stricter check.

slominskir added a commit that referenced this issue Apr 8, 2024
slominskir added a commit that referenced this issue Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant