fix: rich_dt_m sigma bounds and timeout bad fits
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RG-D run 18355 was stalling, because of a bad fit. I found that setting the lower bound of `sigma` helps make this fit converge. I also added a timeout to the fit routine, which will abort the fit after 10 seconds. However, it seems that RG-D's fits are quite bad for this timeline, but that's a problem for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RG-D run 18355 was stalling, because of a bad fit. I found that setting the lower bound of
sigmahelps make this fit converge. I also added a timeout to the fit routine, which will abort the fit after 10 seconds.However, it seems that RG-D's fits are quite bad for this timeline, but that's a problem for another PR.