Iss476 #1015
Merged
Iss476 #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed for 2016 vertex hit killing
This was
linked to
issues
Jan 9, 2024
pbutti
approved these changes
Jan 23, 2024
sarahgaiser
requested changes
Jan 23, 2024
steering-files/src/main/resources/org/hps/steering/analysis/SVTHitPlots.lcsim
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/kalman/SvtHitEfficiencyKalman.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/kalman/SvtHitEfficiencyKalman.java
Outdated
Show resolved
Hide resolved
|
I didn't have time to review this in detail yet, but from a first glance, it would be nice to work on the formatting and to possibly refactor some of the super big |
sarahgaiser
requested changes
Jan 24, 2024
steering-files/src/main/resources/org/hps/steering/analysis/PhysicsRun2016SVTHitEffKalman.lcsim
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
sarahgaiser
requested changes
Jan 25, 2024
tracking/src/main/java/org/hps/recon/tracking/SlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/SlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/SlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/SlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
sarahgaiser
requested changes
Jan 25, 2024
tracking/src/main/java/org/hps/recon/tracking/SlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/SlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/KalmanSlopeBasedTrackHitKiller.java
Outdated
Show resolved
Hide resolved
sarahgaiser
requested changes
Jan 29, 2024
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/TrackHitKiller.java
Outdated
Show resolved
Hide resolved
…sedTrackHitKiller to extend SlopeBasedTrackHitKiller to get rid of redundent code
sarahgaiser
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be all set with killing L1 strip clusters-on-track for MC based on the track slope for both GBL and KF tracks. Included are steering files for 2016.
Also included with this push is code to kill (per sensor) strip clusters based on the actual positions on the sensor (StripHitKiller.java) based off of the driver org.hps.svt.SVTHitLevelPlots.java. No warrantee expressed or implied for this code though. My next next push will include updated SVTHitLevelPlots-like drivers for both GBL and Kalman tracks, along with (hopefully) changes to the code that implements killing based on these that gives reasonable results.