All the Hit Reconstruction Optimizations Rory has worked on #1043
Conversation
|
I'll fix the conflicts myself in a bit. In the meanwhile it'd be helpful for you to make some of the comments you forsee me needing to implement. Also I intend on pushing the hpstr analysis scripts soon as well, but that can be later. I can put the scripts I used to run all the analysis made within the hps-mc framework, but that is in the future. |
recon/src/main/java/org/hps/recon/filtering/UnbiasedTriggerFilterDriver.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/FittedRawTrackerHit.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/NearestNeighborRMSClusterer.java
Outdated
Show resolved
Hide resolved
Finished this one
commit 5
Fixed the damn thang :) Biscuits and Gravy
cbravo135
changed the title
| Collection<ShapeFitParameters> doublePulse = twoPulseFitter.fitShape(rth, shape); | ||
| double doublePulseChiProb = doublePulse.iterator().next().getChiProb(); | ||
| ShapeFitParameters Hello = doublePulse.iterator().next(); |
There was a problem hiding this comment.
Please change this variable name to something descriptive and not Hello.
| } | ||
|
|
||
| } // End of loop over seeds | ||
|
|
||
| // Finished finding clusters | ||
| return cluster_list; | ||
| } | ||
| //WILL RETURN THE LIST OF SPLIT CLUSTERS, THOUGH NOT CHECKED BY SIGNIFICANCE |
There was a problem hiding this comment.
Does this have to be all caps?
| //WILL RETURN THE LIST OF SPLIT CLUSTERS, THOUGH NOT CHECKED BY SIGNIFICANCE | ||
| private ArrayList<List<LCRelation>> hasV(List<LCRelation> cluster){ | ||
| ArrayList<Integer> vloc = new ArrayList<Integer>(); | ||
| int minChan=1000000; |
There was a problem hiding this comment.
can you update the formatting in this part of the code so that we have whitespace around =, ||, &&, <, >, and other operators? This just makes it easier to read. Same for the loops and if statements:
for (int I=0; I < cluster.size(); I++) { ...
reads a bit better than for(int I=0;I<cluster.size();I++){
| int minChan=1000000; | ||
| int maxChan=-1; | ||
| //CHANNELS AREN'T ORDERED PROPERLY, SO YOU HAVE TO ORDER THEM | ||
| for(int I=0;I<cluster.size();I++){ |
There was a problem hiding this comment.
usually, we use lower case indices i, j, k, ... in (nested) for loops.
This is the first in likely a long set of messages required to get the code pretty enough to folks liking. I am submitting the reconstruction hps-java code w/ relevant testing and regular use steering files. The steering files to use will be the one with VSplit in the name as it has all the changes that have been validated to work.