Merging Kalman Filter for pattern recognition - iss204 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… given set of hits to a helix but does allow for field non-uniformity. TBD is to add hit-selection and removal capability, to make it into a pattern recognition tool, and eventually to interface it into the HPS code.
…ow hit selection code to be developed. Also added a hook for the field map.
…orm field not working.
…d. The residuals in the last layer are not quite right, but the errors on the helix parameters after smoothing appear to be perfect.
instead of the piecewise helix. It makes little difference in the result.
…ectly with the non-uniform field. Also corrected the formatting in many files.
… to start the filter, with good results.
…rs. Formatting cleanup.
…nates. Cleaned up comments and formatting in several pieces of code.
…improved some debug printout.
|
I am now seeing a different error, may be easy to fix, but I don’t know how:
…-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.hps.recon.tracking.ComparisonTest
[INFO][org.hps.conditions.database] Opening connection ...
connection: jdbc:mysql://hpsdb.jlab.org:3306/
host: hpsdb.jlab.org
port: 3306
user: hpsuser
database: hps_conditions
java.lang.RuntimeException: org.lcsim.conditions.ConditionsManager$ConditionsNotFoundException: Conditions not found for detector HPS-EngRun2015-Nominal-v7-0-fieldmap
at org.lcsim.event.base.BaseLCSimEvent.<init>(BaseLCSimEvent.java:208)
at org.lcsim.lcio.LCIOEvent.<init>(LCIOEvent.java:62)
at org.lcsim.lcio.LCIOEvent.<init>(LCIOEvent.java:25)
On Dec 4, 2019, at 8:35 PM, normangraf ***@***.***> wrote:
Well "tests shouldn't be affected" is different from "test run." The following test doesn't run:
T E S T S
Running org.hps.recon.tracking.kalman.KalmanInterfaceTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.232 sec <<< FAILURE! - in org.hps.recon.tracking.kalman.KalmanInterfaceTest
testKalman(org.hps.recon.tracking.kalman.KalmanInterfaceTest) Time elapsed: 0.141 sec <<< ERROR!
java.io.FileNotFoundException: ap_recon_0000-fullGBL-new.slcio (No such file or directory)
Please point me to a copy of this file and I can help fix this.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#644?email_source=notifications&email_token=ABDD7YQ2I2Z5H3GJJ27PWDLQXBLHHA5CNFSM4JVSC4X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7FANY#issuecomment-561926199>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDD7YSF6C2M2UIHJISS5Z3QXBLHHANCNFSM4JVSC4XQ>.
|
…s is used, anyway, only for refitting existing GBL tracks (Miriam's original interface), not for the pattern recognition.
|
HI Maurik, |
turning angle from origin to the SSD plane and intersection with that plane
…ts. Introduced timing cuts.
|
Hi All,
|
omar-moreno
requested changes
Feb 18, 2020
tracking/src/main/java/org/hps/recon/tracking/kalman/LineFit.java
Outdated
Show resolved
Hide resolved
|
Histogram.java and TestMain.java are there to facilitate stand-alone test
with a toy MC. Linking in Root and Aida for that purpose is a non-starter
with me. Aida is used in the drivers to run on read data and MC.
LineFit.java is not used and can be deleted. The same applies to
ParabolaFit.java (not mentioned above).
Robert
…On Tue, Feb 18, 2020 at 10:07 AM Omar Moreno ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In tracking/src/main/java/org/hps/recon/tracking/kalman/Histogram.java
<#644 (comment)>:
> @@ -0,0 +1,155 @@
+package org.hps.recon.tracking.kalman;
This doesn't belong in the Kalman filter package. We should either dump
plots to ROOT via AIDA or create a generic object to persist the
information which can then be processed with hpstr.
------------------------------
In tracking/src/main/java/org/hps/recon/tracking/kalman/LineFit.java
<#644 (comment)>:
> @@ -0,0 +1,69 @@
+package org.hps.recon.tracking.kalman;
This is a good class to have but it should be put into a common fitting
package and not the Kalman filter package. It can also be dropped in Utils.
------------------------------
In tracking/src/main/java/org/hps/recon/tracking/kalman/TestMain.java
<#644 (comment)>:
> @@ -0,0 +1,24 @@
+package org.hps.recon.tracking.kalman;
This should be removed and replaced by a Unit Test. It also has a hard
coded path ...
------------------------------
In tracking/src/main/java/org/hps/recon/tracking/kalman/Vec.java
<#644 (comment)>:
> @@ -0,0 +1,144 @@
+package org.hps.recon.tracking.kalman;
We should probably use the existing vector class that is used throughout
our classes. This is OK for now, but should be deprecated at some point.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#644?email_source=notifications&email_token=ABTFRZE2OWD3R66QQGLXZ7TRDQPXBA5CNFSM4JVSC4X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVUS57I#pullrequestreview-359214845>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTFRZA5PQKC5ZHS76BKQ4TRDQPXBANCNFSM4JVSC4XQ>
.
--
Robert P. Johnson
Professor
Physics Department
Santa Cruz Institute for Particle Physics
1156 High St
Santa Cruz, CA 95064
831-459-2125
rjohnson@ucsc.edu
|
|
Removed Linear and Parabola Fits. |
mrsolt
approved these changes
Feb 18, 2020
omar-moreno
approved these changes
Feb 18, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the Kalman Pattern recognition package from Robert's development branch