Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readout for singles2 trigger #841

Merged
merged 1 commit into from
Apr 6, 2021
Merged

update readout for singles2 trigger #841

merged 1 commit into from
Apr 6, 2021

Conversation

tongtongcao
Copy link
Contributor

The readout system is updated to optionally process all singles triggers, and a readout steering file for singles2 trigger is added.

cbravo135
cbravo135 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this flexibility to the code.

normangraf
normangraf approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested the functionality, but the code and steering file look OK.
Please proceed.

@tongtongcao tongtongcao merged commit 209ab6a into master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normangraf normangraf normangraf approved these changes

@cbravo135 cbravo135 cbravo135 approved these changes

@bloodyyugo bloodyyugo Awaiting requested review from bloodyyugo

@mholtrop mholtrop Awaiting requested review from mholtrop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tongtongcao @cbravo135 @normangraf