Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kalman dev #850

Merged
merged 4 commits into from
May 1, 2021
Merged

Kalman dev #850

merged 4 commits into from
May 1, 2021

Conversation

pbutti
Copy link
Contributor

@pbutti pbutti commented Apr 23, 2021

Kalman dev

@cbravo135
Copy link
Collaborator

cbravo135 commented Apr 24, 2021 •
edited
Loading

This branch is quite a bit behind master at the moment. Please consider pulling master and rerunning your checks to make sure everything is still good after merging in the current master. git will be able to merge automatically via the normal recursive strategy, so don't worry about that (I already did this). I am currently running a few checks of this myself.

@pbutti
Copy link
Contributor Author

pbutti commented Apr 24, 2021 •
edited
Loading

Hi Cam,

Thank you for checking this!
I don't think it's necessary to pull master, merge locally and rerun, as only these 3 commits are added to the master. The difference with master are already shows by the PR, and that's what matters. The kalman_dev Will be the same as master after the merge.

cbravo135
cbravo135 approved these changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a few files with this and iss837, and master all merged. Look reasonable to me. I also checked that is passes the integration tests.

@cbravo135
Copy link
Collaborator

cbravo135 commented Apr 27, 2021 •
edited
Loading

The results from running on the 2019 sample partitions, currently at https://www.slac.stanford.edu/~bravo/KF_vs_GBL_Tight_pBot_2019/KF_vs_GBL_Tight_pBot_2019.html use these three commits.

normangraf
normangraf approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds new functionality and fixes a few known issues.
Does not affect legacy reconstruction.
Code builds and tests pass.
Please proceed.

@pbutti pbutti merged commit 35a073f into master May 1, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbravo135 cbravo135 cbravo135 approved these changes

@normangraf normangraf normangraf approved these changes

@robertprestonjohnson robertprestonjohnson Awaiting requested review from robertprestonjohnson

@bloodyyugo bloodyyugo Awaiting requested review from bloodyyugo

@omar-moreno omar-moreno Awaiting requested review from omar-moreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbutti @cbravo135 @normangraf @robertprestonjohnson