Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kalman dev #859

Merged
merged 3 commits into from
May 11, 2021
Merged

Kalman dev #859

merged 3 commits into from
May 11, 2021

Conversation

pbutti
Copy link
Contributor

@pbutti pbutti commented May 10, 2021

Fix on preliminary cuts on search strategies.

@robertprestonjohnson
Fix some problems found by Norman when looking for tracks flagged by …
cdeb483 
…ECAL clusters. All some hit sharing by candidate tracks that get raised from the dead. Fixed bugs in early cuts made on seed formation, which were meant to speed up the code, and set those cuts better, based on distributions obtained from good tracks. More debug printout and histograms, and small adjustments to some default cuts, including addition of two seed strategies.
@robertprestonjohnson
Forgot in the previous commit to remove a debug printout. That is fix…
f2ce3ea 
…ed here.
@robertprestonjohnson
Turned off a debug printout
14d891f
normangraf
normangraf approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please proceed.

@cbravo135
Copy link
Collaborator

Are there any studies that show what these changes do? Where can I read about these problems and how this proposed solution fixes them. I don't think this has been discussed with much of a audience yet.

@pbutti
Copy link
Contributor Author

pbutti commented May 11, 2021

Yo Cam,
studies are in dev. This is the result and interaction between Norman and Robert to try to increase the number of track candidates at reconstruction level. It will provide more tracks (but the quality is still not clear).
A more systematic study, with the metrics that Alic helped preparing will be done later on.

@pbutti pbutti merged commit 13371f9 into master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normangraf normangraf normangraf approved these changes

@omar-moreno omar-moreno omar-moreno approved these changes

@cbravo135 cbravo135 Awaiting requested review from cbravo135

@bloodyyugo bloodyyugo Awaiting requested review from bloodyyugo

@robertprestonjohnson robertprestonjohnson Awaiting requested review from robertprestonjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbutti @cbravo135 @omar-moreno @normangraf @robertprestonjohnson