Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rare cases where KF track extrapolation fails #861

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

alspellm
Copy link
Contributor

Fixed rare bug in TrackClusterMatcherMinDistance. Check to make sure that trackstate at Ecal exists before matching Track to clusters. If no trackstate at Ecal, match this Track to null Cluster.

Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checks for required objects to not be null and acts accordingly if they are with this change. I have ran on a file locally with this and see no issues.

@bloodyyugo
Copy link
Contributor

what branch is this?

@pbutti
Copy link
Contributor

pbutti commented Jun 2, 2021

Why is this not being merged to Master?

@cbravo135 cbravo135 merged commit 140919c into JeffersonLab:master Jun 2, 2021
@normangraf
Copy link
Contributor

This appears to have been on some private repo.

@cbravo135 cbravo135 linked an issue Jun 3, 2021 that may be closed by this pull request
@cbravo135
Copy link
Collaborator

Alic's fork is not private. I was easily able to pull and test his code with the information provided on this page due to how clear it is about what the PR is proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Rare LCSIM null trackstate error
5 participants