Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPS detector for running at 1.92 GeV #863

Merged
merged 3 commits into from
May 20, 2021
Merged

HPS detector for running at 1.92 GeV #863

merged 3 commits into from
May 20, 2021

Conversation

omar-moreno
Copy link
Collaborator

Resolves #862

@omar-moreno omar-moreno added this to the v5.1 milestone May 18, 2021
@omar-moreno omar-moreno self-assigned this May 18, 2021
@omar-moreno omar-moreno marked this pull request as draft May 18, 2021 19:51
@omar-moreno omar-moreno marked this pull request as ready for review May 18, 2021 22:27
Copy link
Contributor

@tongtongcao tongtongcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup for const B and field map looks good. Setup for header looks proper. Other setup is the same as HPS-v2019-3pt7GeV.
The detector configuration for 1.92 GeV seems good. I approve it.

@omar-moreno
Copy link
Collaborator Author

I need to add one more thing then I will merge. Thanks everyone.

@omar-moreno omar-moreno merged commit a7890f9 into master May 20, 2021
@omar-moreno omar-moreno deleted the iss862 branch August 15, 2022 17:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create detector for running at 1.92 GeV using 2019 HPS detector
3 participants