Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify PhysicsRun2019MCRecon.lcsim to solve a bug #876

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Modify PhysicsRun2019MCRecon.lcsim to solve a bug #876

merged 3 commits into from
Jun 10, 2021

Conversation

tongtongcao
Copy link
Contributor

Modify PhysicsRun2019MCRecon.lcsim to solve a bug that the Ecal cluster corrections are applied twice when recon particles by both GBL and KF tracks. Meanwhile, following what we did for 2016 MC, pedestals from DB are applied for MC, instead of running pedestal. So EcalRunningPedestal is removed.

@tongtongcao
Modify PhysicsRun2019MCRecon.lcsim to solve the bug that the Ecal clu…
c537de9 
…ster corrections are applied twice when recon particles by both GBL and KF tracks
cbravo135
cbravo135 requested changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official recommendation for 2019 of the analysis working group is to use KF tracking only. https://confluence.slac.stanford.edu/display/hpsg/5.26.2021+Weekly?preview=/311544557/311546122/210526_kfSummary.pdf

Please change the order of ReconParticleDriver_Kalman and ReconParticleDriver and the configuration so the ecal cluster corrections are based on matching to the KF tracks. I do not mind to making this change for you if you want.

@tongtongcao
Copy link
Contributor Author

tongtongcao commented Jun 10, 2021 •
edited
Loading

The official recommendation for 2019 of the analysis working group is to use KF tracking only. https://confluence.slac.stanford.edu/display/hpsg/5.26.2021+Weekly?preview=/311544557/311546122/210526_kfSummary.pdf

Please change the order of ReconParticleDriver_Kalman and ReconParticleDriver and the configuration so the ecal cluster corrections are based on matching to the KF tracks. I do not mind to making this change for you if you want.

I personally agree with you, Cameron. Please make the change as you suggested.

@normangraf
Copy link
Contributor

The steering file PhysicsRun2019MCRecon_LCIO.lcsim also needs to be modified.
Both steering files are also missing the OtherElectrons_KF collection name in the ReconParticleDriver_Kalman section.

@cbravo135
Copy link
Collaborator

@normangraf Done

@cbravo135 cbravo135 linked an issue Jun 10, 2021 that may be closed by this pull request
Fix bug in MC reconstruction steering files #875
Closed
@normangraf
Copy link
Contributor

@normangraf Done

Thank you.

@JeremyMcCormick JeremyMcCormick merged commit 6ba74e2 into master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloodyyugo bloodyyugo bloodyyugo approved these changes

@cbravo135 cbravo135 cbravo135 approved these changes

@mholtrop mholtrop Awaiting requested review from mholtrop

@normangraf normangraf Awaiting requested review from normangraf

@pbutti pbutti Awaiting requested review from pbutti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bug in MC reconstruction steering files
5 participants
@tongtongcao @normangraf @cbravo135 @bloodyyugo @JeremyMcCormick