Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Hodo monitoring #885

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Fix the Hodo monitoring #885

merged 1 commit into from
Aug 24, 2021

Conversation

rafopar
Copy link
Contributor

@rafopar rafopar commented Aug 23, 2021

The Hodo hit collection is not 'SimpleGenericObject' anymore, but rather 'CalorimeterHit', The collection name is changed, and variable asignment satememts also changed.

…her 'CalorimeterHit', The collection name is changed, and variable asignment satememts also changed.
@rafopar
Copy link
Contributor Author

rafopar commented Aug 23, 2021

It worked for me after those changes.

@bloodyyugo
Copy link
Contributor

It almost works! For "matched hit energies" only one plot is filling and it has a lot of 0s for some reason...

@rafopar
Copy link
Contributor Author

rafopar commented Aug 23, 2021

Yes that is correct.

Others were not present event in the 2019 run.

It was more of diagnostic, just was testing something.
Later if I will have time, will popolate others as well, but it is not critical.

Copy link
Contributor

@bloodyyugo bloodyyugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Rafo

@normangraf
Copy link
Contributor

Does this cause any problems of backwards-compatibility with the 2019 data?

@rafopar
Copy link
Contributor Author

rafopar commented Aug 24, 2021

No, I have tested this on 2019 data.

Before the reconstruction was making genericobjects for Hodo hits, now the recon produces Calorimeter hits, so accordingly I had to change the monitoring app to read from Calorimeter hits, instead of the genericObject.

@bloodyyugo
Copy link
Contributor

Probably for lcio files written before Maurik's changes (when?) but running from evio it's fine.

@rafopar
Copy link
Contributor Author

rafopar commented Aug 24, 2021

Yes, slcio file format got different.
I believe this change happened by the end of 2019, or early 2020.

Yes it is fine with EVIO.

Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please proceed.

@rafopar
Copy link
Contributor Author

rafopar commented Aug 24, 2021

Thanks

@rafopar rafopar merged commit b02f103 into master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants