-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Hodo monitoring #885
Conversation
…her 'CalorimeterHit', The collection name is changed, and variable asignment satememts also changed.
It worked for me after those changes. |
It almost works! For "matched hit energies" only one plot is filling and it has a lot of 0s for some reason... |
Yes that is correct. Others were not present event in the 2019 run. It was more of diagnostic, just was testing something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Rafo
Does this cause any problems of backwards-compatibility with the 2019 data? |
No, I have tested this on 2019 data. Before the reconstruction was making genericobjects for Hodo hits, now the recon produces Calorimeter hits, so accordingly I had to change the monitoring app to read from Calorimeter hits, instead of the genericObject. |
Probably for lcio files written before Maurik's changes (when?) but running from evio it's fine. |
Yes, slcio file format got different. Yes it is fine with EVIO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please proceed.
Thanks |
The Hodo hit collection is not 'SimpleGenericObject' anymore, but rather 'CalorimeterHit', The collection name is changed, and variable asignment satememts also changed.