Iss883

[pbutti]

• Added front-back fitting of tracks with KF
• Fixes to KF pattern reco

[JeremyMcCormick]

Just a quick tip based on scanning your code:

If you want your comments to show up as documentation in the javadoc attached to classes and methods then enclose them like this:

/**
  * This will show up in the javadoc!
  */
class MyClass {
    /**
      * So will this!
      */
      void something() {}
}

Double-slash comments will not:

// This will not show up in the javadoc. :(
void something() {}

Non-javadoc style is more appropriate for internal comments within methods.

Just mentioning this because you have some documentation-style comments on classes and methods but they will be stripped out if someone is looking at the online javadoc and won't be visible at all there.

[JeremyMcCormick]

Also, a few more stylistic nitpicks:

We don't typically prepend underscores in Java code like this within this codebase:

_materialManager

Instead to clearly denote a class variable you can just use this.materialManager within the code. This will use the class variable even if materialManager was another variable declared in the method scope.

And here you may want to extract some of these hard-coded numbers out into constants:

Double chi1 = new Double(p1*t1.chi2s / t1.hits.size() + 300.*(1.0 - (double)t1.hits.size()/14.));

You can then change them easily in one spot and their meaning becomes much clearer to anyone reading the code.

[normangraf]

I've not done an in-depth review, but all tests pass.
Please proceed.