Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix survey #903

Merged
merged 10 commits into from
Mar 23, 2022
Merged

Fix survey #903

merged 10 commits into from
Mar 23, 2022

Conversation

pbutti
Copy link
Contributor

@pbutti pbutti commented Mar 22, 2022

This PR aims to fix the issue of having the survey constants hardcoded in the geometry package.

  • The survey constants are now inside HPS_Nominal_2019SensorSurvey_iter0 compact and can be clearly see them applied.
  • The effect of the corrections has been tested against the previous code and produced the exact same location of the corrections.
  • The geometry code has been stripped from the hardcoded values (the lines of code have been left there for future reference)
  • Some additional commits have made them way in this PR:
    • A detector with 1mm opening used during early reconstruction / alignment tests during operation
    • A driver for printing the alignment hierarchy
    • Minor changes to plotting axes
    • One change on the number of hits cuts

Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see a correction to this oversight in implementation.

@cbravo135 cbravo135 merged commit 2dbcb29 into master Mar 23, 2022
@cbravo135 cbravo135 mentioned this pull request Apr 19, 2022
@cbravo135 cbravo135 linked an issue May 5, 2022 that may be closed by this pull request
@pbutti pbutti deleted the fix_survey branch March 30, 2023 10:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove 2019 hardcoded survey
3 participants