-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix survey #903
Fix survey #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to have resolved the issues caused by the hard-coded 2019 survey constants. See some performance plots at:
https://indico.slac.stanford.edu/event/7159/contributions/3647/attachments/1546/4043/20220323_CalibrationReconstruction_Graf_HPS_Weekly_Meeting.pdf
compared to those at:
Test all run successfully to completion.
Please proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see a correction to this oversight in implementation.
This PR aims to fix the issue of having the survey constants hardcoded in the geometry package.