Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readout system for application of DAQ configuration #905

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

tongtongcao
Copy link
Contributor

Previously, a new readout system was developed for pulser data merging.
For this PR, the readout system is updated with application of DAQ configuration.
A steering file is developed to process readout with single trigger for MC signal + pulser data as input.

@cbravo135 cbravo135 linked an issue May 5, 2022 that may be closed by this pull request
@cbravo135
Copy link
Collaborator

The issue related to this PR is already closed, maybe that should not have been closed?

@tongtongcao
Copy link
Contributor Author

tongtongcao commented May 21, 2022

The issue related to this PR is already closed, maybe that should not have been closed?

The issue is reopened.

Copy link
Member

@JeremyMcCormick JeremyMcCormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me based on the fact that the changes are new code for readout overlay or changing of method accessibility. It doesn't appear to me any "old" readout configurations should be effected. I am assuming the updates have been well-tested.

@tongtongcao
Copy link
Contributor Author

It looks fine to me based on the fact that the changes are new code for readout overlay or changing of method accessibility. It doesn't appear to me any "old" readout configurations should be effected. I am assuming the updates have been well-tested.

It tested well. Actually, it has been applied for MC production with pulser data merging as background

@tongtongcao tongtongcao merged commit 6880545 into master Jun 22, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates for the new readout system with pulser data merging
4 participants