-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment updates #908
Alignment updates #908
Conversation
This PR modifies only files related to alignment and monitoring, with no impact on reconstruction chain.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you PF for making some nice additions to the alignment monitoring.
@@ -105,12 +105,13 @@ protected void process(EventHeader event) { | |||
//accumulatedTracks.add(track); | |||
accumulatedBTracks.add(new BilliorTrack(track)); | |||
|
|||
if (track.getTrackStates().get(0).getTanLambda() > 0) { | |||
//Avoid tracks too close to the beamline to have a more reliable result on z from single volumes | |||
if (track.getTrackStates().get(0).getTanLambda() > 0.035) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think these configuration parameters should be put into a steering file and not hard coded. Hard coding selections should be avoided in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. But this code is only for monitoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine
I have another iteration with the configurable selections. We should develop a trackSelector tool to keep those selections in a single place. At the moment they are copied everywhere multiple times. |
Fixed compilation error due to duplicated setMomC
No description provided.