Fixing iss887 #919
Fixing iss887 #919
Conversation
… channels in 2021 in the IterateGainFactorDriver
…019SF_parameters_data.dat
Fix formatting.
Added new detector for the single pass running at 1.92GeV
Getting latest changes from master in iss887
|
|
||
|
|
||
| public void setBadChannels() { | ||
| if (this.calibYear==2021) { |
There was a problem hiding this comment.
I don't think we should be hard coding bad channel lists like this. The database is the preferred solution for these sorts of things.
There was a problem hiding this comment.
This is a calibration driver, not used at all in reconstruction/analysis, so not sure it's such a big deal. There are gains in the database already which are appropriate for killing a channel in reconstruction and are already used for such. And, since this is reading a gains file during calibrations, they can/should be killed from there too, so we can probably just delete or at least ignore these hard-coded numbers.
|
|
||
| public final class ClusterPositionCorrection2021 { | ||
| // Parameterizations tested in MC using v3-fieldmap | ||
| // Nov 2015 |
There was a problem hiding this comment.
We should use the database here rather than hard code numbers like this. Also, the code has a comment that these were tested on Nov 2015. I would like to see these tested them the 2021 beam energy and fieldmap.
ECAL 2021 energy calibration.