-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patches to KF-based Alignment Pipeline #938
Merged
cbravo135
merged 10 commits into
JeffersonLab:master
from
tomeichlersmith:tomeichlersmith/traj-ali-nhits-cut
Dec 5, 2022
Merged
Patches to KF-based Alignment Pipeline #938
cbravo135
merged 10 commits into
JeffersonLab:master
from
tomeichlersmith:tomeichlersmith/traj-ali-nhits-cut
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete trajectories
this was causing the cut to eventually overflow and go down to zero allowing all tracks to pass the hit cut, defining a local variable allows the cut to change depending on the type of track (KF or GBL)
- apply nhits cut in a way that makes it obvious which track type uses which cut - multiply nhits by 2 if the hits stored in the tracker are helicalcross which is really a combination of 2 tracker hits to make a 3D point
pbutti
approved these changes
Dec 2, 2022
- the debug printout should be a warning since the user should not be seeing it if they are using the drivers properly - add some more comments explaining rational for code and potential roadmap - remove unnecessary total counting of tracks
cbravo135
approved these changes
Dec 5, 2022
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few small but important changes to the KF-based alignment pipeline that are required for it to function properly.
delete
method for GblTrajectoryJna which is necessary to avoid a memory leak causing the alignment pipeline to crash on some systems. This crash was more common with KF-based alignment since KF produced more tracks which therefore created more GBL trajectories which therefore leaked more memory.To Do