Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tanLambda cuts #939

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

sarahgaiser
Copy link
Collaborator

work in progress

@pbutti
Copy link
Contributor

pbutti commented Dec 3, 2022

Hi Sarah, the cuts should be done at track reconstruction level instead at plotting level.
Making cuts at track reconstruction level (i.e. SimpleGBLTrajAliDriver) would harmonize what is used for alignment and what is used for monitoring.
In fact the tanLambda cuts can already be applied at that stage see:
https://github.com/JeffersonLab/hps-java/blob/master/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java#L352

@cbravo135
Copy link
Collaborator

Hi PF, there are times when I personally run GBLOutputDriver and not SimpleGBLTrajAliDriver, and would like to be able to have these kinds of cuts possible there too.

@cbravo135 cbravo135 requested a review from pbutti December 5, 2022 18:53
@pbutti
Copy link
Contributor

pbutti commented Mar 30, 2023

Is it clear why CI fails?

@JeremyMcCormick JeremyMcCormick changed the title add tanLambda cuts Add tanLambda cuts Apr 6, 2023
@cbravo135
Copy link
Collaborator

Relaunched CI and they passed. @pbutti

@sarahgaiser sarahgaiser merged commit 3a1be8f into JeffersonLab:master Apr 21, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants