-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Github Actions plus cleanup and updates to POM files #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-github-actions Implement GitHub actions
…t-github-actions Correct maven-release-plugin version and additional cleanup
…t-github-actions Correct maven args command
…t-github-actions Correct path to bin jar and disable shade plugin from creating extra files
…t-github-actions Attempt to skip deployment of all modules besides distribution
…t-github-actions Add write permissions to release workflow
…nt-github-actions Feature/issue 959/implement GitHub actions
This reverts commit ad18c79.
…nt-github-actions Change fork repo to JLab
JeremyMcCormick
requested review from
omar-moreno,
cbravo135 and
tomeichlersmith
April 10, 2023 22:37
Co-authored-by: Tom Eichlersmith <31970302+tomeichlersmith@users.noreply.github.com>
tomeichlersmith
approved these changes
Apr 11, 2023
sarahgaiser
approved these changes
Sep 5, 2023
required: true | ||
|
||
jobs: | ||
# TODO: Add test here for a sanity check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still an active todo?
I can do this later in another PR.
…On Tue, Sep 5, 2023 at 1:26 PM sarahgaiser ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In .github/workflows/release.yml
<#975 (comment)>
:
> + default: true
+ deploy_site:
+ description: "Update the project website"
+ required: false
+ type: boolean
+ default: true
+ secrets:
+ SSH_PRIVATE_KEY:
+ required: true
+ CI_DEPLOY_USERNAME:
+ required: true
+ CI_DEPLOY_PASSWORD:
+ required: true
+
+jobs:
+ # TODO: Add test here for a sanity check
Is this still an active todo?
—
Reply to this email directly, view it on GitHub
<#975 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQXV42W4HFEHPZ7DYAUP3DXY5VEVANCNFSM6AAAAAAWURLTDI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Github Actions for hps-java CI/CD.
The new workflows are as follows:
deploy
- Deploys the snapshot (development) jars whenever the master branch is updatedrelease
- Performs the Maven release, creates the Github release page, (optionally) updates the project website, and bumps the development versionsite
- Deploys the project website to gh-pagestest
- Runs the tests for PRs (replaces the oldmaven.yml
workflow file)All of these can be run manually through the "Actions" tab in the project.
Additionally, I made a cleanup pass on all the project POM files and some other project configuration, including the following:
dependencyManagement
section of the main POMMy TODO list before un-drafting:
After being approved, this should be merged to master as a "squash commit" to avoid unwanted messages from the branch history (from merge commits, test releases, etc.).