Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track state at target #996

Merged
merged 19 commits into from
Jul 25, 2023
Merged

Add track state at target #996

merged 19 commits into from
Jul 25, 2023

Conversation

alspellm
Copy link
Contributor

@alspellm alspellm commented Jun 8, 2023

Extrap track to target and make new track state where track params ref = (trackX,trackY,0), therefore d0 = 0.
trackY position may replace d0 if using this track state in analysis.

Track reference point is set to (trackX, trackY, trackZ), so track position at target is saved.

May want to change track param reference point to ref = (trackX,0,0), so that d0 != 0.

These track states only exist if target position is set in steering-file KalmanPatRecDriver.

…arget tracks, save tracks with relations to AtIP tracks. To turn on tracks at target, must pass target position in steering-file under KalmanPatRecDriver
if (case2){
double [] paramsRefPoint = {finalPos.x(), finalPos.y(), 0.0};
bts.setReferencePoint(paramsRefPoint);
double[] newRef = {-4.3, 0.0, 0.0};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to change -4.3 to target_z

@alspellm
Copy link
Contributor Author

alspellm commented Jun 9, 2023 via email

…ta class. Allows us to calculate track momentum using curvature later, instead of having to create a new TrackData collection to hold 3-momentum for each Track State
@alspellm alspellm requested a review from pbutti June 19, 2023 20:15
@normangraf
Copy link
Contributor

normangraf commented Jun 20, 2023

Instead of having magic code triggered by the addition of the targetPosition variable please add a boolean which explicitly states what is going to happen followed by the target location, such as

<createTrackStateAtTargetPosition>true</createTrackStateAtTargetPosition>
<targetPosition>-4.3</targetPosition>

@alspellm alspellm merged commit 7871a8e into JeffersonLab:master Jul 25, 2023
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants