Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss993 #999

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Iss993 #999

merged 3 commits into from
Jun 16, 2023

Conversation

bloodyyugo
Copy link
Contributor

Adds per-sensor & per-phase SVT hit time corrections for 2019/2021 datasets using constants from resource files.

See this JIRA issue: HPSANA-1
and sub-issues.

@cbravo135 cbravo135 linked an issue Jun 13, 2023 that may be closed by this pull request
Read in SVT sensor- and phase-dependent timing offsets via resource file #993
Closed
cbravo135
cbravo135 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes tests. There are plenty of different conditions here that would justify putting these into the database, Matt G promised me he will do that after pass1.

@pbutti
Copy link
Contributor

pbutti commented Jun 16, 2023

approved

@cbravo135 cbravo135 merged commit 4312f9f into master Jun 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbravo135 cbravo135 cbravo135 approved these changes

@pbutti pbutti pbutti approved these changes

@normangraf normangraf Awaiting requested review from normangraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read in SVT sensor- and phase-dependent timing offsets via resource file
3 participants
@bloodyyugo @pbutti @cbravo135