Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sms.GetSmsSessionDetailsAsync issue #341

Merged

Conversation

pvgritsenko-ansible
Copy link
Contributor

Sorry, it's me again.
We need to fix Sms.GetSmsSessionDetailsAsync method. I used wrong formatting (not UTC) parameter for datetime arguments 'to' and 'from' and it doesn't work if we set non-null to these parameters.

I apologize for bothering you again with this new feature...

@pvgritsenko-ansible
Copy link
Contributor Author

pvgritsenko-ansible commented Apr 11, 2024

There is also issue with SmsAttachmentType.Jpg. It is described as 'JPG' in Zoom documentation, but actually they send 'JPG/JPEG'. That is the reason why SmsAttachmentType is updated

@pvgritsenko-ansible pvgritsenko-ansible changed the title Sms.GetSmsSessionDetailsAsync datetime arguments цкщтп ащкьфеештп Sms.GetSmsSessionDetailsAsync issue Apr 11, 2024
@Jericho Jericho added the Bug This change resolves a defect label Apr 11, 2024
@Jericho Jericho added this to the 0.75.2 milestone Apr 11, 2024
Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jericho Jericho merged commit 4599542 into Jericho:develop Apr 11, 2024
2 checks passed
@Jericho
Copy link
Owner

Jericho commented Apr 11, 2024

🎉 This issue has been resolved in version 0.75.2 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This change resolves a defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants