Skip to content

Commit

Permalink
🩹 (semantic) add back semantic-release-commit-filter [b] (#1492)
Browse files Browse the repository at this point in the history
Yup #1491 _does not_ filter at a high-level for each individual workspace anymore. Good times. 😂

**Whoops** add back `semantic-release-commit-filter`
  • Loading branch information
JeromeFitz authored Jun 23, 2024
1 parent d3c3676 commit 048bce0
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/release-notes-generator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ May move to `remark` once `semantic-release` is ESM.
Also add the `changelog-config` customization:

```sh
yarn add @jeromefitz/release-notes-generator @jeromefitz/conventional-gitmoji
pnpm add @jeromefitz/release-notes-generator @jeromefitz/conventional-gitmoji --save-dev
```
2 changes: 1 addition & 1 deletion packages/release-notes-generator/release.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const { name } = pkg
const branches = [
...configDefault.branches,
{ name: 'NICE-70', prerelease: 'canary' },
{ name: 'feat/semantic-esm', prerelease: 'canary' },
{ name: 'fix/semantic-workspace-check', prerelease: 'canary' },
]

const configPassed = {
Expand Down
2 changes: 0 additions & 2 deletions packages/release-notes-generator/src/utils/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ function generate(options, commits, context, keyCommit) {

if (options.ignoreReverted) {
for (const commit of filterRevertedCommitsSync(commits)) {
// console.dir(`>> generate :: filterRevertedCommitsSync`)
// console.log(commit)
filteredCommits.push(commit)
}
} else {
Expand Down
1 change: 1 addition & 0 deletions packages/semantic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"dependencies": {
"@semantic-release/git": "10.0.1",
"semantic-release": "24.0.0",
"semantic-release-commit-filter": "1.0.2",
"title": "3.5.3"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/semantic/release.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const { name } = pkg

const branches = [
...configDefault.branches,
{ name: 'feat/semantic-esm', prerelease: 'canary' },
{ name: 'fix/semantic-workspace-check', prerelease: 'canary' },
]

const configPassed = {
Expand Down
1 change: 1 addition & 0 deletions packages/semantic/src/getConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const getConfig = (configPassed = {}): SemanticReleaseOptions => {
// const configInit: SemanticReleaseOptions = {
const configInit: any = {
branches: [{ name: 'main' }, { name: 'canary', prerelease: 'canary' }],
extends: ['semantic-release-commit-filter'],
plugins,
tagFormat: `v\${version}`,
}
Expand Down
6 changes: 6 additions & 0 deletions packages/utils/release.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,14 @@ const pkg = require('./package.json')

const { name } = pkg

const branches = [
...configDefault.branches,
{ name: 'fix/semantic-workspace-check', prerelease: 'canary' },
]

const configPassed = {
...configDefault,
branches,
tagFormat: `${name}@\${version}`,
}

Expand Down
8 changes: 8 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 048bce0

Please sign in to comment.