✨ (eslint) NICE-129 continued flat config upgrade #1511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript-eslint
Continue migration to
eslint@9
New Rules
This has the potential to be a b/r/e/a/k/i/n/g change, reason being there seems to be some new rules due to moving packages. Specifically around:
@typescript-eslint/consistent-type-definitions
: Use aninterface
instead of atype
no-extra-boolean-cast
: Redundant double negationno-empty-pattern
: Unexpected empty object patternThese all should probably be fixed but will be
ignored
for now and addressed later.Applications importing this package will need to do the same. At the risk of bumping a major every single time we upgrade package(s) from
eslint@8
=>eslint@9
we are going to use@jeromefitz/eslint-conifg@4
as a holding pattern.Packages
Add
@types/eslint__js
@eslint/compat
@eslint/js
eslint-plugin-import-x
(migrated fromeslint-plugin-import
)typescript-eslint
Remove
eslint-plugin-import
(migrated toeslint-plugin-import-x
)typescript-eslint/eslint-plugin
Please Note: This is continual as the eslint ecosystem continues to slowly (but surely) move to
eslint@9
. There are some hacks currently to be able to account for config|plugin that are@8
. They will continue to be removed / updated.Refactor
Needed to add back some rules that have gone away from recommended plugins/configs.
Apply Formatting
@todo(NICE-129)
to identify that we should update these, but should not within this PRConfiguration
@typescript-eslint/parser@7.15.0
outputLogs: "new-only"
(away fromerrors-only
)Closes #1507