Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when rewinding with the threaded software renderer enabled #81

Closed
JesseTG opened this issue Oct 10, 2023 · 4 comments
Closed

Crashes when rewinding with the threaded software renderer enabled #81

JesseTG opened this issue Oct 10, 2023 · 4 comments
Labels
bug Something isn't working
Milestone
Ready for Submiss...

Comments

@JesseTG
Copy link
Owner

JesseTG commented Oct 10, 2023

No description provided.

@JesseTG JesseTG added the bug Something isn't working label Oct 10, 2023
@JesseTG JesseTG mentioned this issue Oct 10, 2023
Closed
@JesseTG
Copy link
Owner Author

JesseTG commented Oct 10, 2023

This might be a threading issue; the crash has to do with the rendering thread modifying data while the main thread is saving or loading state.

@JesseTG JesseTG changed the title Crashes when rewinding with the threaded software renderer enabled Crashes when rewinding with the threaded software renderer enabled (Linux) Oct 10, 2023
@JesseTG JesseTG added the linux For issues related to Linux. label Oct 12, 2023
@JesseTG JesseTG removed the linux For issues related to Linux. label Oct 22, 2023
@JesseTG JesseTG changed the title Crashes when rewinding with the threaded software renderer enabled (Linux) Crashes when rewinding with the threaded software renderer enabled Oct 22, 2023
This was referenced Oct 24, 2023
Merged
Open
@JesseTG
Copy link
Owner Author

JesseTG commented Oct 27, 2023

I seem to be able to fix this, but my fix introduces a new bug; namely, the screen flickers on each frame where a savestate is taken (presumably due to the extra time spent).

If I can't make measurable progress on this by tomorrow, I'm just gonna exclude the threaded renderer so I can ship this thing.

@JesseTG
Copy link
Owner Author

JesseTG commented Oct 30, 2023

Pending a review of this PR upstream, I've decided to exclude the threaded software renderer until this issue is properly fixed. The maintainer who's most able to provide insight is indisposed with school.

This ticket will remain open until then.

@JesseTG JesseTG mentioned this issue Oct 30, 2023
Closed
@JesseTG JesseTG added the help wanted Extra attention is needed label Oct 31, 2023
@JesseTG JesseTG added this to the Standalone Feature Parity milestone Nov 7, 2023
@JesseTG
Copy link
Owner Author

JesseTG commented Jan 9, 2024

Fixed.

@JesseTG JesseTG closed this as completed Jan 9, 2024
@JesseTG JesseTG removed the help wanted Extra attention is needed label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Ready for Submission to RetroArch Dis...
Development

No branches or pull requests
1 participant
@JesseTG