Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slirp library includes
<compat/strl.h>
but never definesHAVE_STRL
. On the other handlibretro-common
may be compiled withHAVE_STRL
and may rely on the system strlcat/strlcpy functions. This lead to link error becauselibretro-common
is compiled withoutcompat/compat_strl.c
whileslirp
try to use libretro-common strlcat/strlcpy functions.Use
target_link_libraries
instead of onlytarget_include_directories
, to transmit the definitions oflibretro-common
toslirp
.