Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_convert_with_custom_writer unnecessarily skipped on macos #240

Closed
jayvdb opened this issue Nov 23, 2021 · 0 comments · Fixed by #241
Closed

test_convert_with_custom_writer unnecessarily skipped on macos #240

jayvdb opened this issue Nov 23, 2021 · 0 comments · Fixed by #241

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Nov 23, 2021

temporary named files on macos appear to often contain uppercase, e.g.

test_convert_with_custom_writer (__main__.TestPypandoc) ... /Users/jayvdb
skipped 'pandoc has problems with uppercase filenames, got /var/folders/j6/q46zbprs12n5ds9z7zytq5mm0000gn/T/tmp_m2kmsmtfoo-bar+baz/tmp0c8m2kjc.lua'

The skip is helpfully described as caused by jgm/pandoc#4610 , which has now been fixed, so the skip should be unnecessary, and it definitely is unnecessary for me on macos, py39 and py27
jayvdb added a commit to jayvdb/pypandoc that referenced this issue Nov 23, 2021
@jayvdb
tests.py: Remove unnecessary skip
0ef15b9 
The upstream bug has been fixed.

Closes JessicaTegner#240
jayvdb added a commit to jayvdb/pypandoc that referenced this issue Nov 23, 2021
@jayvdb
tests.py: Remove unnecessary skip
4226dd8 
The upstream bug has been fixed.

Closes JessicaTegner#240
@jayvdb jayvdb mentioned this issue Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests.py: Remove unnecessary skip jayvdb/pypandoc
1 participant
@jayvdb