Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for javax.sql.ConnectionPoolDataSource #902

Closed
qoomon opened this issue May 3, 2020 · 1 comment
Closed

Support for javax.sql.ConnectionPoolDataSource #902

qoomon opened this issue May 3, 2020 · 1 comment

Comments

@qoomon
Copy link
Contributor

qoomon commented May 3, 2020 •
edited
Loading

Following code does not compile, due to no support for javax.sql.ConnectionPoolDataSource for Database.connect(pooldatasource)

val datasource: javax.sql.ConnectionPoolDataSource = com.impossibl.postgres.jdbc.PGConnectionPoolDataSource()
val database = Database.connect(datasource)
Tapac added a commit that referenced this issue May 3, 2020
@Tapac
Support for javax.sql.ConnectionPoolDataSource #902
fe585cb
@Tapac
Copy link
Contributor

Tapac commented May 3, 2020

Fixed in master.

@Tapac Tapac closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tapac @qoomon