Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like an infinite recursion in 'match' sql-operator #978

Closed
LoneEngineer opened this issue Jun 25, 2020 · 3 comments
Closed

Seems like an infinite recursion in 'match' sql-operator #978

LoneEngineer opened this issue Jun 25, 2020 · 3 comments
Labels

Comments

@LoneEngineer
Copy link

Version: 0.22.1

If I run query with 'match' operator, I got

Caused by: java.lang.StackOverflowError
	at java.base/java.lang.ThreadLocal.get(ThreadLocal.java:163)
	at org.jetbrains.exposed.sql.transactions.TransactionManager$Companion.getManager(TransactionApi.kt:81)
	at org.jetbrains.exposed.sql.transactions.TransactionManager$Companion.currentOrNull(TransactionApi.kt:90)
	at org.jetbrains.exposed.sql.transactions.TransactionManager$Companion.current(TransactionApi.kt:92)
	at org.jetbrains.exposed.sql.vendors.DefaultKt.getCurrentDialect(Default.kt:669)
	at org.jetbrains.exposed.sql.SqlExpressionBuilderClass.match(SQLExpressionBuilder.kt:283)
	at org.jetbrains.exposed.sql.SqlExpressionBuilderClass.match(SQLExpressionBuilder.kt:283)
....

Issue seems to be here (in master version):

/** Checks if this expression matches the specified [pattern] using the specified match [mode]. */

@Tapac
Copy link
Contributor

Tapac commented Jun 25, 2020

Could you please check with 0.26.1 and share a little bit longer stacktrace?

@Tapac Tapac added the bug label Jun 25, 2020
@LoneEngineer
Copy link
Author

LoneEngineer commented Jun 26, 2020

@Tapac
Just checked with 0.26.1. Problem is still there. Stacktrace is changed a bit:

java.lang.StackOverflowError
	at |b|b|b(Coroutine boundary.|b(|b)
	at io.ktor.routing.Routing.executeResult(Routing.kt:147)
	at io.ktor.routing.Routing.interceptor(Routing.kt:34)
	at io.ktor.routing.Routing$Feature$install$1.invokeSuspend(Routing.kt:99)
	at io.ktor.features.ContentNegotiation$Feature$install$1.invokeSuspend(ContentNegotiation.kt:107)
	at io.ktor.features.StatusPages$interceptCall$2.invokeSuspend(StatusPages.kt:101)
	at io.ktor.features.StatusPages.interceptCall(StatusPages.kt:100)
	at io.ktor.features.StatusPages$Feature$install$2.invokeSuspend(StatusPages.kt:140)
	at io.ktor.features.CallLogging$Feature$install$1$invokeSuspend$$inlined$withMDC$1.invokeSuspend(CallLogging.kt:226)
	at io.ktor.features.CallLogging$Feature$install$1.invokeSuspend(CallLogging.kt:230)
	at io.ktor.server.testing.TestApplicationEngine$callInterceptor$1.invokeSuspend(TestApplicationEngine.kt:292)
	at io.ktor.server.testing.TestApplicationEngine$2.invokeSuspend(TestApplicationEngine.kt:50)
	at io.ktor.server.testing.TestApplicationEngine$handleRequest$pipelineJob$1.invokeSuspend(TestApplicationEngine.kt:290)
	at kotlinx.coroutines.DeferredCoroutine.await$suspendImpl(Builders.common.kt:99)
	at io.ktor.server.testing.TestApplicationEngine$handleRequest$1.invokeSuspend(TestApplicationEngine.kt:151)
Caused by: java.lang.StackOverflowError
	at java.base/java.lang.ThreadLocal.get(ThreadLocal.java:163)
	at org.jetbrains.exposed.sql.transactions.TransactionManager$Companion.getManager(TransactionApi.kt:87)
	at org.jetbrains.exposed.sql.transactions.TransactionManager$Companion.currentOrNull(TransactionApi.kt:96)
	at org.jetbrains.exposed.sql.transactions.TransactionManager$Companion.current(TransactionApi.kt:98)
	at org.jetbrains.exposed.sql.vendors.DefaultKt.getCurrentDialect(Default.kt:735)
	at org.jetbrains.exposed.sql.ISqlExpressionBuilder$DefaultImpls.match(SQLExpressionBuilder.kt:292)
	at org.jetbrains.exposed.sql.SqlExpressionBuilder.match(SQLExpressionBuilder.kt:405)
	at org.jetbrains.exposed.sql.ISqlExpressionBuilder$DefaultImpls.match(SQLExpressionBuilder.kt:292)
	at org.jetbrains.exposed.sql.SqlExpressionBuilder.match(SQLExpressionBuilder.kt:405)
	at org.jetbrains.exposed.sql.ISqlExpressionBuilder$DefaultImpls.match(SQLExpressionBuilder.kt:292)
	at org.jetbrains.exposed.sql.SqlExpressionBuilder.match(SQLExpressionBuilder.kt:405)
... last two lines repeat a lot of time here ....

I think the issue with following code (even IDEA reports about 'recursive call') in org.jetbrains.exposed.sql.ISqlExpressionBuilder:
image

Issue found in tests using H2 engine.

@Tapac
Copy link
Contributor

Tapac commented Jul 3, 2020

Oh. now I see. It was broken with #829. Will be fixed in next release.
Thank you for a report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants