Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResultRow creation #1452

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Fix ResultRow creation #1452

merged 1 commit into from
Feb 19, 2022

Conversation

naftalmm
Copy link
Contributor

@naftalmm naftalmm commented Feb 7, 2022

This PR not only fixes #1435 (which is a rather specific use-case) but also improves performance of the ResultRow.create method if some fields of ResultSet are NULL.

@naftalmm
fallback to default implementation of IColumnType.readObject method…
80c3157 
… only if `columnType` is unknown (not if its actual implementation of this method returned `null`)
@stengvac
Copy link
Contributor

stengvac commented Feb 16, 2022 •
edited
Loading

@naftalmm
Do we merge it or wait?

@naftalmm
Copy link
Contributor Author

naftalmm commented Feb 16, 2022 •
edited
Loading

@stengvac
I haven't got write access to this repository, so we're waiting for someone, who has)

@Tapac Tapac merged commit d776ca5 into JetBrains:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stengvac stengvac stengvac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom null cases are difficult to work with.
3 participants
@naftalmm @stengvac @Tapac