fix: EXPOSED-171 Switch from spring.factories to AutoConfiguration.imports (#1636)

[rbraeunlich]

Some documentation for reference:

• Change in auto-configuration files (Spring Boot 3 Migration Guide)
• Change in test H2 version (Spring Boot 3 Dependency)
• Recommended ways to exclude classes from auto-configuration (Spring Boot Reference)
• Testing auto-configuration using ApplicationContextRunner (Spring Boot Reference)

[bog-walk]

Hi @rbraeunlich , I realize that this PR was opened a while go, but please let me know if you're available to work on it if I request some changes. Or if you're willing to have me checkout the branch and push changes directly.

Thanks in advance!

[rbraeunlich]

Hi @bog-walk
whatever works best for you. I don't mind to apply any changes.

[bog-walk]

Please also update the following files:

buildSrc/.../Versions.kt

• Bump springFramework to 6.0.11
• Bump springBoot to 3.1.3

exposed-spring-boot-starter/build.gradle.kts

• Bump H2 testImplementation to Versions.h2_v2

exposed-spring-boot-starter/test/.../ExposedAutoConfigurationTest.kt

• Add the following test to the ExposedAutoConfigurationTest class:

@Test
fun testClassExcludedFromAutoConfig() {
    val contextRunner = ApplicationContextRunner().withConfiguration(
        AutoConfigurations.of(Application::class.java)
    )
    contextRunner.run { context ->
        assertThrows(NoSuchBeanDefinitionException::class.java) {
            context.getBean(DataSourceTransactionManagerAutoConfiguration::class.java)
        }
    }
}

exposed-spring-boot-starter/test/.../Application.kt

• Change the annotation to have an exclude:

@SpringBootApplication(exclude = [DataSourceTransactionManagerAutoConfiguration::class])

Fyi, this exclude could also be done using @EnableAutoConfiguration on the test class CustomDatabaseConfigConfiguration or using a property in application.properties, so we should also update the README to cover the options.

README.md

• In the 'Configuring Exposed' section, please change the custom config code block to look like this:

@Configuration
@EnableAutoConfiguration(exclude = [DataSourceTransactionManagerAutoConfiguration::class])
class ExposedConfig {
  @Bean
  fun databaseConfig() = DatabaseConfig {
    useNestedTransactions = true
  }
}

• In the same section, under the code block above, please include all the following text:

It is recommended that the DataSourceTransactionManagerAutoConfiguration class be excluded from auto-configuration, which can be done in a custom configuration, as shown above.

Alternatively, the class can be disabled using the exclude attribute of @SpringBootApplication:

@SpringBootApplication(exclude = [DataSourceTransactionManagerAutoConfiguration::class])
class MyApplication

See the official documentation for more options to exclude auto-configuration classes.

[rbraeunlich]

All done @bog-walk

[bog-walk]

@rbraeunlich Just to keep you updated:

We're working on our jvmToolchain. Once that PR is merged, I'll let you know and ask you to rebase so you can set the spring modules to use jdk17, which should fix the failed build. Shouldn't be long.

[bog-walk]

@rbraeunlich Please rebase from main to get the recently merged jvmToolchain changes. Then set the jdk in both exposed-spring-boot-starter and spring-transaction modules from 8 to the required 17.

[rbraeunlich]

All done @bog-walk

[bog-walk]

Thanks for all your help with this PR @rbraeunlich !

[e5l]

@rbraeunlich, thanks for the PR! LGTM