fix: Fix tables creation depending on each other via foreignKey constraint #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySoshin
approved these changes
Dec 29, 2022
naftalmm
force-pushed
the
fix_tables_creation_with_foreign_key_reference
branch
from
53f9cff
to
cf1f837
Compare
e5l
approved these changes
Aug 17, 2023
...test/kotlin/org/jetbrains/exposed/sql/tests/shared/ddl/CreateMissingTablesAndColumnsTests.kt
Outdated
Show resolved
Hide resolved
|
@naftalmm Thanks for adding tests. Could you please rebase on the |
…: fix table sorting by references, simplify code
naftalmm
force-pushed
the
fix_tables_creation_with_foreign_key_reference
branch
from
915c1bd
to
7f653d7
Compare
joc-a
approved these changes
Sep 4, 2023
joc-a
changed the title
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…raint (JetBrains#1649) * fix tables creation depending on each other via foreignKey constraint: fix table sorting by references, simplify code * add tests in case there are two tables (parent and child), with the child table referring the parent by the means of a composite foreign key only, the reference is not taken into account by the call SchemaUtils.create and, subsequently, by SchemaUtils.sortTablesByReferences this causes the SchemaUtils to try to create the child table first, resulting in an SQL error: CREATE TABLE IF NOT EXISTS child ..., CONSTRAINT fk_name FOREIGN KEY (col1, col2) REFERENCES parent(col1 col2) ... [42102-199]. Statement(s): ... Table parent not found --------- Co-authored-by: Jocelyne <38375996+joc-a@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1643