fix: Allow exec() transform block to return null if ResultSet is empty #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @micheljung. Thank you for your contribution. Could you please add a test that covers this change? |
If the ResultSet contains no result, the user wants to return `null`. However, since `executeQuery()` returns a non-nullable ResultSet, the user is forced to return a non-null object, even if there is no result. By allowing `transform` to return null, this is fixed.
bog-walk
changed the title
e5l
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ResultSet contains no result, the user wants to return
null. However, sinceexecuteQuery()returns a non-nullable ResultSet, the user is forced to return a non-null object, even if there is no result.By allowing
transformto return null, this is fixed.