refactor: Adjust kotlinx-serialization & postgresql dependencies in core #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in core Remove kotlinx-serialization-json dependency from exposed-core: - Remove json()/jsonb() table functions that use implicit serializer (and place them in exposed-tests as samples). - Refactor jsonExtract() to either use columnType mapping for primitive types or user-defined serializer/deserializer, if provided, with JsonColumnType. Make org.postgresql dependency in exposed-core compileOnly: - Refactor JsonColumnType.valueFromDB() to only check for PGobject is PostgreSQ> is being used. Add kotlinx-serialization-json dependency to exposed-tests: - Add json/jsonb table function overrides as sample for user-defined use. - Add jsonExtract() override as example of how it can be simplified for non-primitive tpyes. - Refactor the 3 datetime modules' build files and test source similarly.
|
Closed in favour of moving dependencies to a new module - #1793. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove kotlinx-serialization-json dependency from exposed-core:
serializer<T>()(and place them in exposed-tests as samples).jsonExtract()to either use columnType mapping for primitive types or user-defined serializer/deserializer, if provided, withJsonColumnType.Make org.postgresql dependency in exposed-core
compileOnly:JsonColumnType.valueFromDB()to only check for PGobject if PostgreSQL is being used.Add kotlinx-serialization-json dependency to exposed-tests:
jsonExtract()override as example of how it can be simplified for non-primitive types.