chore: Modify max_line_length value in .editorconfig to match that of detekt.yml #1790

joc-a · 2023-07-11T11:38:16Z

Modify max_line_length value in .editorconfig to match that of detekt.yml
Modify detekt IntelliJ plugin configuration in detekt.xml because the fields were not being applied correctly
Remove more detekt issues before merging chore: Integrate detekt with GitHub Actions #1765

e5l · 2023-07-14T07:31:33Z

.editorconfig

@@ -6,9 +6,9 @@ end_of_line = lf
 indent_size = tab
 indent_style = space
 insert_final_newline = true
-max_line_length = 150
+max_line_length = 166


I would use 120 and format (or ignore line with detekt comment)

@e5l How do we decide on a number? 120 is the default for detekt, but I think it's too small (for my screen at least).

Changing it from 166 to 120 will add detekt MaxLineLength warnings to more than 40 files and will break the build, so this will need to be done in a separate PR after this one is merged.

bog-walk

I made a lot of changes inside Suspended.kt and ThreadLocalTransactionManager.kt in the last merge, so you'll most likely need to rebase and resolve some conflicts.

bog-walk · 2023-07-14T14:28:48Z

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/Constraints.kt

-            name ?: "fk_${fromTable.tableNameWithoutSchemeSanitized}_${
-                from.joinToString("_") { it.name }
-            }__${target.joinToString("_") { it.name }}"
+            name ?: (
+                "fk_${fromTable.tableNameWithoutSchemeSanitized}_${from.joinToString("_") { it.name }}__" +
+                    target.joinToString("_") { it.name }
+                )


Everything looks good. This is the only one that isn't showing up for me locally as an error/warning, so I'm not sure if there's still something not syncing up with the detekt configuration.

It shows up when you run ./gradlew detekt

… detekt.yml

The fields were not being applied correctly :')

joc-a force-pushed the joc/detekt-issues-part-3 branch from d0b1345 to 8339823 Compare July 11, 2023 12:16

joc-a marked this pull request as ready for review July 11, 2023 17:49

joc-a force-pushed the joc/detekt-issues-part-3 branch 3 times, most recently from 02d11bb to 46a29b6 Compare July 13, 2023 13:12

joc-a requested review from bog-walk and e5l July 13, 2023 14:18

e5l approved these changes Jul 14, 2023

View reviewed changes

joc-a force-pushed the joc/detekt-issues-part-3 branch 2 times, most recently from b078f5b to d97a369 Compare July 14, 2023 10:55

joc-a changed the title ~~chore: Modify max_line_length value in .editorconfig to match that of detekt.yml~~ chore: Modify max_line_length value in .editorconfig and detekt.yml from 166 to 120 Jul 14, 2023

bog-walk approved these changes Jul 14, 2023

View reviewed changes

joc-a force-pushed the joc/detekt-issues-part-3 branch from d97a369 to ce4174b Compare July 17, 2023 08:56

joc-a changed the title ~~chore: Modify max_line_length value in .editorconfig and detekt.yml from 166 to 120~~ chore: Modify max_line_length value in .editorconfig to match that of detekt.yml Jul 17, 2023

joc-a force-pushed the joc/detekt-issues-part-3 branch 2 times, most recently from 15fdd98 to f8e4c06 Compare July 17, 2023 09:38

joc-a added 8 commits July 17, 2023 11:39

chore: Remove VariableNaming detekt issues

e06356f

chore: Remove Indentation detekt issues

9a0aa7c

chore: Modify max_line_length value in .editorconfig to match that of…

5974fe9

… detekt.yml

chore: Remove SpreadOperator detekt issue

50cc057

chore: Remove MaximumLineLength detekt issues

2d2f1a4

chore: Suppress PackageNaming detekt issues

043afbd

fix: Modify detekt IntelliJ plugin configuration in detekt.xml

cd226bf

The fields were not being applied correctly :')

chore: Suppress LongParameterList detekt issue

e2f3417

joc-a force-pushed the joc/detekt-issues-part-3 branch from f8e4c06 to e2f3417 Compare July 17, 2023 09:42

joc-a merged commit 06983eb into main Jul 17, 2023

joc-a deleted the joc/detekt-issues-part-3 branch July 17, 2023 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Modify max_line_length value in .editorconfig to match that of detekt.yml #1790

chore: Modify max_line_length value in .editorconfig to match that of detekt.yml #1790

joc-a commented Jul 11, 2023 •

edited

Loading

e5l Jul 14, 2023

joc-a Jul 14, 2023

joc-a Jul 17, 2023

bog-walk left a comment

bog-walk Jul 14, 2023

joc-a Jul 17, 2023 •

edited

Loading

chore: Modify max_line_length value in .editorconfig to match that of detekt.yml #1790

chore: Modify max_line_length value in .editorconfig to match that of detekt.yml #1790

Conversation

joc-a commented Jul 11, 2023 • edited Loading

e5l Jul 14, 2023

Choose a reason for hiding this comment

joc-a Jul 14, 2023

Choose a reason for hiding this comment

joc-a Jul 17, 2023

Choose a reason for hiding this comment

bog-walk left a comment

Choose a reason for hiding this comment

bog-walk Jul 14, 2023

Choose a reason for hiding this comment

joc-a Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

joc-a commented Jul 11, 2023 •

edited

Loading

joc-a Jul 17, 2023 •

edited

Loading